Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write unit tests #138

Open
jamesgeorge007 opened this issue Oct 1, 2019 · 10 comments
Open

Write unit tests #138

jamesgeorge007 opened this issue Oct 1, 2019 · 10 comments
Labels
help wanted Extra attention is needed

Comments

@jamesgeorge007
Copy link
Member

jamesgeorge007 commented Oct 1, 2019

There is an action handler for each command. You can also find a couple of helper functions consumed by the respective handler. We need to write unit tests to ensure that the helpers serve their purpose.

@jamesgeorge007 jamesgeorge007 added Hacktoberfest Valid for Hacktoberfest-2020 help wanted Extra attention is needed labels Oct 1, 2019
@anooppoommen
Copy link

@jamesgeorge007 Hey is this up for grabs

@jamesgeorge007
Copy link
Member Author

@anooppoommen yeah, it is 👍 Let me know the command that you're willing to work on.

@anooppoommen
Copy link

@jamesgeorge007 I'll work on the mevn init function for now

@cherryWood55
Copy link

I want to work on this issue.

@jamesgeorge007
Copy link
Member Author

@cherryWood55 you may take up a command other than mevn init

@evaporei
Copy link

evaporei commented Oct 5, 2019

Where is the mevn init unit test?

@jamesgeorge007
Copy link
Member Author

@otaviopace as of now we are missing out on unit tests (testing out the workflow in isolation). Feel free to pick up a command that you wish to work upon.

@ThakurKarthik
Copy link
Contributor

@jamesgeorge007 i am taking mev info.Is it okay?

@jamesgeorge007 jamesgeorge007 removed the Hacktoberfest Valid for Hacktoberfest-2020 label Nov 2, 2019
@meroware
Copy link
Contributor

meroware commented Oct 4, 2020

@jamesgeorge007 I shall take generate if no one else has https://github.com/madlabsinc/mevn-cli/blob/develop/src/commands/basic/generate.js. But I did notice that there is no jest setup for unit tests only e2e. I can include the setup in my PR as well, but wondering what's the plan on that part.

@jamesgeorge007
Copy link
Member Author

@meroware thanks for showing interest, we don't have any unit tests at the moment. Feel free to shoot a PR.

@jamesgeorge007 jamesgeorge007 added the Hacktoberfest Valid for Hacktoberfest-2020 label Oct 12, 2020
@jamesgeorge007 jamesgeorge007 removed the Hacktoberfest Valid for Hacktoberfest-2020 label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants