Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to kleur #157

Closed
jamesgeorge007 opened this issue Dec 27, 2019 · 7 comments
Closed

Migrate to kleur #157

jamesgeorge007 opened this issue Dec 27, 2019 · 7 comments
Labels
dependencies Proposals or PR's relating to dependency updates help wanted Extra attention is needed
Projects
Roadmap

Comments

@jamesgeorge007
Copy link
Member

Since the bundle size is a concern.
@jamesgeorge007 jamesgeorge007 added help wanted Extra attention is needed dependencies Proposals or PR's relating to dependency updates feature-request Proposal for a new feature labels Dec 27, 2019
@jamesgeorge007 jamesgeorge007 added this to ToDo in Roadmap via automation Dec 27, 2019
@jamesgeorge007 jamesgeorge007 changed the title chore(deps): switch to kleur chore(deps): migrate to kleur Mar 29, 2020
@jamesgeorge007 jamesgeorge007 changed the title chore(deps): migrate to kleur Migrate to kleur Mar 29, 2020
@jamesgeorge007 jamesgeorge007 removed the feature-request Proposal for a new feature label Mar 29, 2020
@imrishabh18
Copy link

@jamesgeorge007 Hey, i am a beginner can i work on this issue ?

@jamesgeorge007
Copy link
Member Author

@imrishabh18 yeah sure 👍

@imrishabh18
Copy link

imrishabh18 commented Apr 1, 2020 •
edited

@jamesgeorge007 Can you please explain me,What should i do to migrate to kleur ?

@jamesgeorge007
Copy link
Member Author

jamesgeorge007 commented Apr 1, 2020 •
edited

Just install kleur as a dependency - npm install --save kleur
We no longer need chalk - npm uninstall --save chalk
Hereafter you can go forward updating all instances of chalk with kleur. Make sure that you refer the API docs.

@imrishabh18
Copy link

I was checking the API docs of kleur they are using this format to import colors const { red, blue } = require('kleur') . But this mevn-cli are using some import statement. So, how do i work around this ? And can you please also tell me where can i see the changes i am making in the code in action.

@jamesgeorge007
Copy link
Member Author

jamesgeorge007 commented Apr 2, 2020 •
edited

Our codebase is based on ES6+ standards. Please Read through the contributing guidelines. Do join the chatroom and you can find me there.

@jamesgeorge007
Copy link
Member Author

Not of higher priorities

Roadmap automation moved this from ToDo to Done Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Proposals or PR's relating to dependency updates help wanted Extra attention is needed
Projects
Roadmap
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesgeorge007 @imrishabh18