New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configure MongoDB with mevn generate #178
feat: configure MongoDB with mevn generate #178
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good already 👍
Left a couple of suggestions.
Also, we no longer require this anymore:-
mevn-cli/src/templates/server/basic/server.js Lines 27 to 36 in 568f281
|
@jamesgeorge007 all the review comments are addressed and PR is updated. Please re-review. |
@jamesgeorge007 added missed file rewrite too. Please verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
* feat: add mongodb connection * feat(db): change export to commonjs Co-authored-by: James George <jamesgeorge998001@gmail.com> * feat(db): add additional params in mongoose connect Co-authored-by: James George <jamesgeorge998001@gmail.com> * feat(db): review changes on generate, rearrange helpers * feat: remove unwanted commented code for mongodb conn * fix: write server file back after adding db conn Co-authored-by: James George <jamesgeorge998001@gmail.com>
What kind of change does this PR introduce?
A feature
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Contributes to #176 . ie, adding MongoDB configuration in server.
Does this PR introduce a breaking change?
No
Other information
This is not a working draft you'll get a basic idea on my thought process. I'm very new to this type of application, and there are some grey areas. Please contact in person if possible so that I can clear my doubts @jamesgeorge007