minizip: use default variables/rules in Makefile #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minizip bare Makefile overrides CC/CFLAGS and the default compile/link rules for no reason, which breaks users who want to pass specific CFLAGS/LDFLAGS. These can all be removed: the out-of-box build is unchaged but overriding CFLAGS or LDFLAGS now works as expected. Signed-off-by: Ross Burton <ross.burton@arm.com>
|
cc: @gvollant. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minizip bare Makefile overrides CC/CFLAGS and the default
compile/link rules for no reason, which breaks users who want to pass
specific CFLAGS/LDFLAGS.
These can all be removed: the out-of-box build is unchaged but
overriding CFLAGS or LDFLAGS now works as expected.