Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird lightning:buttonIcon issue #34

Closed
madmax983 opened this issue Dec 12, 2017 · 2 comments
Closed

Weird lightning:buttonIcon issue #34

madmax983 opened this issue Dec 12, 2017 · 2 comments
Labels

Comments

@madmax983
Copy link
Owner

New issue that has cropped up:

If you toggle a child row, then scroll down and scroll back up, the grid is maintaining the state of the hierarchy as expected. However, the lightning:buttonIcon for chevron right and chevron down get rendered rotated 90 degrees.

This is just cropping up in Winter '18.

@madmax983 madmax983 added the bug label Dec 12, 2017
@madmax983
Copy link
Owner Author

Looks like SLDS is now auto-rotating the svg icon 90 degrees when aria-expanded gets set to true. This means we can get rid of the If logic blocks displaying chevron right versus chevron down in cell, and just make sure aria-expanded is getting set correctly on click.

@madmax983
Copy link
Owner Author

On the flip side (ha!): it is rotating all svgs in the th cell, so the edit icon is getting flipped as well. Will need to hack out some css to prevent that.

madmax983 pushed a commit that referenced this issue Dec 12, 2017
madmax983 added a commit that referenced this issue Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant