Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't reinitialize the DataGrid with new data #43

Closed
alexanderyhapcv opened this issue Jan 29, 2018 · 3 comments
Closed

can't reinitialize the DataGrid with new data #43

alexanderyhapcv opened this issue Jan 29, 2018 · 3 comments
Assignees
Labels

Comments

@alexanderyhapcv
Copy link

When trying to update data attribute and calling init() again Grid gets stuck loading

@madmax983 madmax983 self-assigned this Jan 30, 2018
@madmax983 madmax983 added the bug label Jan 30, 2018
@madmax983
Copy link
Owner

Should have a PR to fix this later tonight. I think I am going to introduce a new refresh method, although it will mostly involve fixes to the existing init methods. Just feels more idiomatic to call refresh in this use case, rather then calling init again (unless we changed it to dataInit or something like that?). Thoughts?

madmax983 pushed a commit that referenced this issue Jan 30, 2018
@madmax983 madmax983 mentioned this issue Jan 30, 2018
madmax983 added a commit that referenced this issue Jan 30, 2018
* #43 Data grid now handles data refresh
madmax983 pushed a commit that referenced this issue Jan 30, 2018
madmax983 pushed a commit that referenced this issue Jan 30, 2018
@madmax983
Copy link
Owner

With the refresh method, you should be able to update the data attribute on the grid, call refresh, and have your changes propagate. Let me know if you find anymore issues!

@alexanderyhapcv
Copy link
Author

wow! thanks for a quick response @madmax983 this is exactly what I needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants