Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Laravel requirement #11

Closed
BBrunekreeft opened this issue Oct 27, 2020 · 3 comments
Closed

Drop Laravel requirement #11

BBrunekreeft opened this issue Oct 27, 2020 · 3 comments

Comments

@BBrunekreeft
Copy link
Contributor

BBrunekreeft commented Oct 27, 2020 •
edited
Loading

I'd like to use this package as an alternative for the chumper/zipper package.
I'm not using Laravel, but since Laravel is required in composer.json, the complete Laravel Package is installed.

Is it possible to drop the Laravel requirement from composer.json, so I can use it in my own project?
@theimerj
Copy link
Collaborator

You know what, that is not a bad idea. I will test it tomorrow and if everything goes fine, I will drop the requirement.

@BBrunekreeft
Copy link
Contributor Author

Any news on this. by any chance?

@BBrunekreeft BBrunekreeft mentioned this issue Dec 1, 2020
Merged
@theimerj
Copy link
Collaborator

theimerj commented Dec 1, 2020

Hello, I merged your PR #12 and made a few tweaks, so the tests run smoothly on Github Actions. I am sorry for taking so long.

@theimerj theimerj closed this as completed Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theimerj @BBrunekreeft