-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step indicator of completion steps has wrong color after entering #213
Comments
The reason for the issue is that the completion step is assigned the css classes This combination is then displayed with: angular-archwizard/src/css/wizard-navigation-bar.scss Lines 163 to 168 in 57900c5
|
A possible quick fix for the issue may be to add an additional constraint to the
to: public isCurrent(wizardStep: WizardStep): boolean {
return wizardStep.selected && !this.wizard.completed;
} |
At the moment I do not think that the suggested quick-fix is a good solution, because it reduces the possible expressiveness of the CSS by allowing the removal of the Another more sophisticated solution may be to use |
As far as I understand, the problems stems from the fact that completion steps are marked as completed right after they are navigated to by the user. I think the best course of action would be to adjust the condition when the red
The |
I'm fine with that solution! This will also be more in line with the previous versions of |
After entering a completion step the corresponding step-indicator in the navigation bar is red instead of dark green:
Correct would be if the step indicator is dark green like for the other steps.
The text was updated successfully, but these errors were encountered: