Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support private Repositories #64

Open
SirUli opened this issue Jan 21, 2022 · 3 comments
Open

Support private Repositories #64

SirUli opened this issue Jan 21, 2022 · 3 comments

Comments

@SirUli
Copy link

SirUli commented Jan 21, 2022

As a follow-up to the #63 it would be awesome if you could add support for private repositories (currently they are not (https://github.com/madpah/requirements-parser/blob/master/requirements/parser.py#L72-L76)).

This came out of the detective work for ansible/ansible-builder#319 where I'd love to see these supported.

Thanks in advance!

@eqrx
Copy link

eqrx commented Jan 24, 2022

I wanted to open a PR for it but I noticed that requirements-parser represents actual requirements as the class Requirement and drops everything else (now gracefully, good job :) ). I am wondering how this could be implemented:

  • Allow Requirement to hold an option or a requirement line. I am unsure how to implement that without breaking the API
  • Extra class for options, so a set of Requirement instances would be returned with a set of Option ... but that would also break the current API.

Any thoughts?

@JoelKle
Copy link

JoelKle commented Feb 8, 2022

+1 for supporting private PIP repositories

@Akasurde
Copy link

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants