Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: logger #47

Merged
merged 21 commits into from Jan 6, 2024
Merged

feat: logger #47

merged 21 commits into from Jan 6, 2024

Conversation

jkowalleck
Copy link
Collaborator

@jkowalleck jkowalleck commented Dec 19, 2023 •
edited

Fixes #9.
Supersedes #10

kroeschl and others added 15 commits September 6, 2023 12:10
@kroeschl
Don't let our logging calls mess with the root logger
01987a6
@kroeschl
Correct indentation error
e1adaf3
@jkowalleck
const as UPPERCASE, logger for wanrings, documentation
d5f59ef 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Merge remote-tracking branch 'origin/main' into logging-no-global
44d8ab9
@jkowalleck
suppress mypy for py3.7
d565418 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
fix tests
0da6a35 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
style
9ee1f3a 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Merge remote-tracking branch 'origin/main' into logging-no-global
2443d31
@jkowalleck
style
96893f4 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
log compatibility
1fdc9a6 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
fix compat
e3c8c5f 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
refactor logger declaration in protected, make still public API
190c775 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
reformat docs
117e94c 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
fix tests
1b39831 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Merge remote-tracking branch 'origin/main' into logging-no-global
35cfeae
@jkowalleck jkowalleck added the enhancement New feature or request label Dec 19, 2023
@jkowalleck jkowalleck added this to the 1.0.0 milestone Dec 19, 2023
@jkowalleck jkowalleck mentioned this pull request Dec 19, 2023
Closed
@jkowalleck
NullHandler
e8c4ad1 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
docs
d768939 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
logger name
caec561 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
docs
5509f4c 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
name as before
d5c416b 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title feat!: logger feat: logger Dec 19, 2023
@jkowalleck
Copy link
Collaborator Author

#10 plus some rollbacks and revisions.
Incorporated notes from @kroeschl - #10 (comment)

changes since #10

  • used the existing variable logger - as it was already public API
  • used the existing logger name serializable

@jkowalleck
refactor
28622ba 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
Copy link
Collaborator Author

@kroeschl could I ask you for some feedback?

@jkowalleck jkowalleck mentioned this pull request Dec 27, 2023
Closed
5 tasks
@jkowalleck jkowalleck removed this from the 1.0.0 milestone Dec 27, 2023
@kroeschl
Copy link
Contributor

kroeschl commented Jan 2, 2024

@kroeschl could I ask you for some feedback?

Tested and verified that this does fix #9, and the diff looks good to me.

@jkowalleck jkowalleck merged commit 9269b0e into main Jan 6, 2024
22 checks passed
@jkowalleck jkowalleck deleted the feat/logger branch January 6, 2024 22:37
@jkowalleck
Copy link
Collaborator Author

jkowalleck commented Jan 6, 2024 •
edited

feature was made available in v0.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madpah madpah madpah approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using serializable.serializable_class during import configures root logger
3 participants
@jkowalleck @kroeschl @madpah