Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple clicks on bookmarklet pollute dom stats #3

Closed
cppforlife opened this issue Jan 9, 2011 · 3 comments
Closed

Multiple clicks on bookmarklet pollute dom stats #3

cppforlife opened this issue Jan 9, 2011 · 3 comments

Comments

@cppforlife
Copy link

To reproduce:

  1. Click once on bookmarklet and remember the results.
  2. Close overlay.
  3. Click bookmarklet again and see that dom stats changed (e.g. +2 scrpt tags...)

I didnt look at the code but I imagine that it should be pretty easy to clean up some if not all changes that bookmarklet makes to dom.

@FabianBeiner
Copy link
Contributor

I can't reproduce this. Actually, the script-counting-part checks for "dommonster.js" as script source (and doesn't count it).

@cebjyre
Copy link

cebjyre commented Jan 11, 2011

I'm reproducing it on this very page - the specific script tags warning isn't changing, but the number of elements, nodes, serialized DOM size etc is increasing

@FabianBeiner
Copy link
Contributor

Yes, you're right. I just had a look on the example (script tags), which still don't appear. But indeed, it keeps the old div and script tag in the dom.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants