Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.key namespace is too generic, consider moving to window.keymaster #152

Closed
knutole opened this issue Aug 25, 2015 · 3 comments
Closed

Comments

@knutole
Copy link

knutole commented Aug 25, 2015

I've run into problems with other people's libs overwriting the global keyspace with key (ie window.key). Since key is such a generic name, this problem could be solved with using eg. keymaster instead.

@madrobby
Copy link
Owner

Use noConflict mode (see the Readme).

@knutole
Copy link
Author

knutole commented Aug 25, 2015

This means I'd have to use noConflict before loading any other libs though.

@madrobby
Copy link
Owner

We can't anticipate every eventuality and the library provides a way to change how you call it via noConflict. If you absolutely can't use that, you can fork keymaster and rename the function.

We won't rename the method just because other libraries don't play nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants