Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IE6+ support. #8

Merged
merged 1 commit into from Aug 29, 2011
Merged

Added IE6+ support. #8

merged 1 commit into from Aug 29, 2011

Conversation

scq
Copy link
Contributor

@scq scq commented Aug 29, 2011

I've added support for IE 6 and later.

Also, I added in semicolons in after function declarations, as is best practice. Just remove them if you prefer it without.

@scq
Copy link
Contributor Author

scq commented Aug 29, 2011

Actually, it should now work in any relatively recent pre JavaScript 1.6 browser.

@pthrasher
Copy link

I started working on this myself, then realized it was already done. Thanks... Hopefully this will get merged in.

madrobby added a commit that referenced this pull request Aug 29, 2011
---

Ive added support for IE 6 and later.

Also, I added in semicolons in after function declarations, as is best practice. Just remove them if you prefer it without.
@madrobby madrobby merged commit cca7795 into madrobby:master Aug 29, 2011
@madrobby
Copy link
Owner

Added it, but did some bigger modifications. Was the stuff in addEvent where it added functions on the object to prevent memory leaks? I'm not sure if that would work at all in this situation (and we don't deregister anything), so I've left it out for now.

@scq
Copy link
Contributor Author

scq commented Aug 29, 2011

The addEvent function was actually from a blog post by John Resig. As far as I know, adding the functions to the object was just so they could be removed later. Some of the code was for making sure this was assigned correctly in the callback in IE, but as that's not used in keymaster.js, it's not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants