Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I cannot use this version with webpack on MacOS #1262

Closed
seeLuck opened this issue Feb 4, 2017 · 3 comments
Closed

I cannot use this version with webpack on MacOS #1262

seeLuck opened this issue Feb 4, 2017 · 3 comments

Comments

@seeLuck
Copy link

seeLuck commented Feb 4, 2017

The module cannot be plugged in by webpack, so that the zepto is not defined.

but the v1.1.7 is ok with that.

I can hardly understand the source code but it seems to be some modules issues with v1.2.0.

@mislav
Copy link
Collaborator

mislav commented Feb 6, 2017

There was a patch proposing to fix this: #1211

Can you test if that works?

@ohcibi
Copy link
Contributor

ohcibi commented Feb 16, 2017

I can confirm that this fix works. I.e. I built a project with a script that inserts an html element with zepto. Without this fix I'm getting the expected error caused by this not being window.

@mislav I have an additional question about this. I found various (very old) issues about the zepto-team not wanting to support any kind of module loaders or similar like webpack (those issues were about browserify); but your answer on this issue occurs to me as if that has changed? I found the current version of zepto to be incompatible with browserify as well and I was wondering if issues about those topics are accepted nowadays?
UPDATE: I found the incompatibility with browserify is also caused by #1210 and fixed by #1211. Its just that import $ from "zepto" is not equal with const $ = require("zepto"). In the latter case $ is an empty object and one needs to const $ = window.$ after a plain require("zepto") but that should be an issue of browserify.

@madrobby
Copy link
Owner

madrobby commented Aug 6, 2017

This should work now with the latest master branch. If not, please reopen and let us know what's broken.

@madrobby madrobby closed this as completed Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants