Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable JSCS #629

Closed
nogginbox opened this issue Feb 6, 2014 · 6 comments
Closed

Disable JSCS #629

nogginbox opened this issue Feb 6, 2014 · 6 comments

Comments

@nogginbox
Copy link

Please provide an option to disable JSCS style cop, or just show as warnings rather than break. None of my JS files will compile any more and it's not even giving a reason for all of them.

Update:
After conversation with SLaks it's clear that the compilation failed message is not important and this wasn't actually breaking anything.

However, would still be good to have the option to disable JsHint or JSCS based on preference.

@SLaks
Copy link
Collaborator

SLaks commented Feb 6, 2014

JSCS doesn't compile or break anything.
What exactly is happening?

@nogginbox
Copy link
Author

When I save a JS file it says:

06/02/2014 16:11:00: JsHint: account.js checked.
06/02/2014 16:11:00: JSCS: account.js compilation failed:

It then doesn't minify it.

@SLaks
Copy link
Collaborator

SLaks commented Feb 6, 2014

The compilation failed message is a side-effect of the way the linters are implemented; it doesn't actually mean anything.

This should not affect minifiers at all; are you sure you have Minify On Save enabled for JS in Options?
Also try disabling Lint on Build for JS & see if that helps.

@nogginbox
Copy link
Author

Thanks.

Got minifying working. That was me being an idiot. Minify on save wasn't enabled on this computer.

Would be good to get rid of the compilation failed message. It's confusing.

I still think it would be useful to disable this feature.

@SLaks
Copy link
Collaborator

SLaks commented Feb 6, 2014

Yes; we should fix the output.
You can disable this feature by turning off Lint on Build in JS options.
We currently don't have any way to disable JSCS but not JSHint.

@nogginbox
Copy link
Author

I think it would be nice to be able to choose which you want. But not as pressing feature request, now it's clear that it wasn't stopping the minify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants