Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the abbr tag #40

Closed
xt0rted opened this issue Mar 16, 2015 · 2 comments · Fixed by #41
Closed

Support the abbr tag #40

xt0rted opened this issue Mar 16, 2015 · 2 comments · Fixed by #41

Comments

@xt0rted
Copy link
Contributor

xt0rted commented Mar 16, 2015

Currently abbr is expanded to acronym which isn't a supported tag in html5.
@am11
Copy link
Contributor

am11 commented Mar 16, 2015

Good catch! It seems like it is caused by this line: HtmlElementFactory.cs#L157. We would need to separate this case. (see the comment below)

Would you like to send a PR for fix?

@am11
Copy link
Contributor

am11 commented Mar 16, 2015

IMO, the smart fix would be to just replace:

using (HtmlGenericControl abbr = new HtmlGenericControl("acronym"))

with:

using (HtmlGenericControl abbr = new HtmlGenericControl(tagName))

@xt0rted xt0rted mentioned this issue Mar 16, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support both abbr and acronym tags
2 participants
@xt0rted @am11