Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow glob composes #66

Closed
nwmcsween opened this issue Jun 4, 2017 · 2 comments
Closed

Allow glob composes #66

nwmcsween opened this issue Jun 4, 2017 · 2 comments

Comments

@nwmcsween
Copy link

nwmcsween commented Jun 4, 2017

This is a pretty big change and duplicates some work in postcss-easy-import (glob import). Maybe postcss-modules, postcss-import and postcss-easy-import should be merged (or based off one another) as postcss-modules is basically a class based @import with optional mapping to localized classes.

Consider

.title {
	composes: * from './prefix*.css';
}
@TrySound
Copy link
Contributor

TrySound commented Jun 4, 2017

@nwmcsween There's different mechanism under the hood. They can't be just merged. Also your example has a lot of implicits which reduces mainainability of your modules. You can get large classname in browser which can look like inline styles.

@madyankin
Copy link
Owner

@nwmcsween PostCSS-modules is just a wrapper around CSS Modules core, so it won't introduce any syntax changes, sorry. Regarding the proposal, I agree with @TrySound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants