Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples and tests for Python 3.8 compatibility #94

Merged
merged 2 commits into from Sep 26, 2020
Merged

Update examples and tests for Python 3.8 compatibility #94

merged 2 commits into from Sep 26, 2020

Conversation

tommilligan
Copy link
Contributor

See #86
See #74

This PR fixes up a couple of small issues encountered when upgrading to Python 3.8:

  • updates examples in README.md to be compatible with Python 3.8
  • updates test code to match the formatting example provided in the readme
  • adds Python 3.8 testing to Travis and tox
  • marks the package as Python 3.8 compatible in setup.py

@the-wondersmith
Copy link

Would love to see this available in the mainline PyPi package

@tommilligan
Copy link
Contributor Author

@madzak is there anything else I can do to help this into master?

@browniebroke
Copy link

Had the same issue, and this made the trick, thanks @tommilligan! 👍

@madzak madzak merged commit 35a8ca2 into madzak:master Sep 26, 2020
@madzak
Copy link
Owner

madzak commented Sep 26, 2020

Hi terribly sorry for the HUGE delay but i really appreciate you adding 3.8!

@tirkarthi tirkarthi mentioned this pull request Oct 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tommilligan @the-wondersmith @browniebroke @madzak