Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More sophisticated led patterns in led-sw #491

Closed
MerlijnWajer opened this issue Dec 20, 2020 · 4 comments
Closed

More sophisticated led patterns in led-sw #491

MerlijnWajer opened this issue Dec 20, 2020 · 4 comments

Comments

@MerlijnWajer
Copy link
Member

To be clear, low priority, but I wanted to document this at least.

Currently led-sw allows for r/g/b + on timeout and off timeout.

I wonder if we can add something for multiple points in time, and define how to get to those points.

I guess each point would be have:

  • r/g/b value
  • type: constant, or ramp-to-next-point
  • time for point (for constant, just keep it at this value, for ramp-to-next-point, interpolate with values of next point over time)
@MerlijnWajer
Copy link
Member Author

These are the Fremantle default LED patterns:

image
image
image
image

@MerlijnWajer
Copy link
Member Author

Of course, these patterns would have to be written keeping in mind that changing the LEDs all the time causes a lot of wakeups, so going super fancy does not make a lot of sense, but some patterns (like: charging) could potentially be more fancy. And then users could decide if they wanted different/more fancy patterns at the cost of some battery life.

@IMbackK
Copy link
Collaborator

IMbackK commented Dec 21, 2020

i dont agree with making led-sw more fancy at all. besides the powerconsuption concerns, every device (except pp idk there) has the ability to do patterns in hw. we should do fancy patterns there and led-sw is just a (simple) fallback

@IMbackK
Copy link
Collaborator

IMbackK commented Oct 18, 2021

im going to close this as wontfix, since i dont think doing so makes any sense.
If this kind of pattern is desired device specific modules are needed, like led on cpcap-uc

@IMbackK IMbackK closed this as completed Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants