Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hildon-home "LED-Pattern" xdg desktop notification hint is not honored #641

Open
IMbackK opened this issue Oct 16, 2022 · 2 comments
Open

Comments

@IMbackK
Copy link
Collaborator

IMbackK commented Oct 16, 2022

https://github.com/maemo-leste/hildon-home/blob/0d32a53e8a18b69e9472d56ea26a19cba210a649/src/hd-incoming-events.c#L1387
suggests that hildon-home should activate the corresponding mce led pattern however this dosent happen, no dbus call to mce is ever issued.

how to reproduce:
notify-send -h string:LED-Pattern:PatternCommunicationSMS test
or look as sphones dbus output

expected result: hildon-home activates the corresponding mce pattern
actual result: nothing happens

@MerlijnWajer
Copy link
Member

modest seems to call MCE to get the LED patterns:

void
modest_platform_push_email_notification(void)
{
    gboolean screen_on, app_in_foreground;

    /* Get the window status */
    app_in_foreground = hildon_program_get_is_topmost (hildon_program_get_instance ());

    screen_on = modest_window_mgr_screen_is_on (modest_runtime_get_window_mgr ());

    /* If the screen is on and the app is in the
       foreground we don't show anything */
    if (!(screen_on && app_in_foreground)) {

        modest_platform_play_email_tone ();

        /* Activate LED. This must be deactivated by
           modest_platform_remove_new_mail_notifications */
#ifdef MODEST_HAVE_MCE
        osso_rpc_run_system (modest_maemo_utils_get_osso_context (),
                     MCE_SERVICE,
                     MCE_REQUEST_PATH,
                     MCE_REQUEST_IF,
                     MCE_ACTIVATE_LED_PATTERN,
                     NULL,
                     DBUS_TYPE_STRING, MODEST_NEW_MAIL_LIGHTING_PATTERN,
                     DBUS_TYPE_INVALID);
#endif
    }
}

@IMbackK
Copy link
Collaborator Author

IMbackK commented Nov 11, 2022

Which is also a unnescary duplication, as for modest group notifications hildon home has allready set the email pattern to on due to this behavior being "hardcoded" in hh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants