Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mce: KEY_SCREENLOCK on Droid4? #71

Closed
MerlijnWajer opened this issue Feb 16, 2018 · 6 comments
Closed

mce: KEY_SCREENLOCK on Droid4? #71

MerlijnWajer opened this issue Feb 16, 2018 · 6 comments
Assignees

Comments

@MerlijnWajer
Copy link
Member

See #65

The Droid4 has a KEY_POWER, and VOLUME_UP and VOLUME_DOWN, but no KEY_SCREENLOCK.

Personally, I think both KEY_SCREENLOCK and KEY_POWER do useful stuff on the N900 -- I was wondering if we can perhaps consider KEY_POWER "Held" for a longer time as KEY_SCREENLOCK as well? Or the other way around?

Or perhaps KEY_POWER and VOLUME_UP as KEY_SCREENLOCK ?

@dderby
Copy link
Member

dderby commented Feb 17, 2018

How about single tap KEY_POWER to lock, double tap KEY_POWER to bring up the menu (or the other way around)?

@MerlijnWajer
Copy link
Member Author

Possible, but that would introduce some extra state in MCE I think. The nice thing about held down is that we get it for free from the kernel. And then the moment someone releases it, we check how much time has passed. <2s; power menu. <5s; lock. >5s; power off. Or something like that.

@freemangordon
Copy link

that's already supported by mce/tklock in one way or another - double-click on power key locks the device, etc.

@MerlijnWajer
Copy link
Member Author

What you describe is likely what we need. I'll see if I can get that to work.

@MerlijnWajer
Copy link
Member Author

MerlijnWajer commented Feb 19, 2018

Pressing the power key twice does indeed lock screen, but it can't be used to unlock. That is a problem on the droid4 - you have to open the keyboard slider to then "unlock".

Also -- if anyone still has elogind installed, uninstall it! (It powers off the machine when you press the button...)

@MerlijnWajer MerlijnWajer self-assigned this May 20, 2018
@MerlijnWajer
Copy link
Member Author

New MCE (1.8.128.4) fixes this issue. Use power button once to get power menu, twice to unlock it. When locked, use power button once to get slider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants