Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store.createWriteStream([cb]) callback not calling #1

Closed
finnp opened this issue Aug 13, 2014 · 3 comments
Closed

store.createWriteStream([cb]) callback not calling #1

finnp opened this issue Aug 13, 2014 · 3 comments

Comments

@finnp
Copy link

finnp commented Aug 13, 2014

I understood the documentation that both of this code snippets should do the same:

    var save = store.createWriteStream()
    save.on('finish', function () {
      console.log('done')
    })
    var save = store.createWriteStream(function () {
      console.log('done')
    })

However for me only the event-driven finish version worked. I didn't look into this yet, just wanted to let you know.

@mafintosh
Copy link
Owner

Thanks for reporting this. Fixed in 3.0.2

@finnp
Copy link
Author

finnp commented Aug 13, 2014

Nice! I just had some fun using your module to create a simple gif sharing site: https://github.com/finnp/gif-sharer.

This kitten won't survive another push to heroku though ;)
cat

@max-mapper
Copy link
Collaborator

RIP kitten. here's another one
catgif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants