Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webpack error: the request of a dependency is an expression #10

Merged
merged 2 commits into from Dec 5, 2018
Merged

Fix webpack error: the request of a dependency is an expression #10

merged 2 commits into from Dec 5, 2018

Conversation

0xh0b0
Copy link
Contributor

@0xh0b0 0xh0b0 commented Dec 4, 2018

fixes #7

mafintosh
mafintosh reviewed Dec 4, 2018
View reviewed changes
index.js Show resolved Hide resolved
@0xh0b0 0xh0b0 mentioned this pull request Dec 5, 2018
Closed
@mafintosh mafintosh merged commit 6f01972 into prebuild:master Dec 5, 2018
@mafintosh
Copy link
Collaborator

3.5.1 - Thanks!

@0xh0b0 0xh0b0 mentioned this pull request Dec 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafintosh mafintosh mafintosh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warning in ./node_modules/node-gyp-build/index.js
2 participants
@0xh0b0 @mafintosh