adding missing readable stream dependency

[thlorenz]

• although only used for node < 0.10, it still is required in the code
• for node 0.8 it just breaks when trying to find that module

Actually @rvagg will tell you to always use readable stream to get the same stream interface regardless of your node version.
I can send another PR with that change if you so desire.

However this PR is most important since dependencies that are required (even if only in certain circumstances) need to be included. The saved disk space is not worth the headaches when running modules in different environments and see them breaking.

[thlorenz]

Thanks for merging this so quickly.

Actually I just tried this version with my lib and found that somehow tar-stream gives different results for node 0.8

To try it do clone https://github.com/thlorenz/dockerify and do:

npm install && npm run test-0.8

The tests will not finish, however in node0.10 they work just fine.
As you can see not too much is happening in that module, so I have great reason to believe that tar-stream may not work the same way in node-0.8

Any thoughts?

[mafintosh]

I'm pretty sure your tests are hanging because of the bug I describe in thlorenz/dockerify#1 (you are piping the input stream asynchronously)

[mafintosh]

Also I would certainly merge a PR that changes the module to just use the readable-stream dependency as you describe in your first comment!

[thlorenz]

Ok, will get to that ASAP.

[ctalkington]

oh that was my bad, seems i added it to the wrong section a few months back and hadn't used the module on v0.8 yet besides dev testing.

[ctalkington]

@thlorenz what are you basing this statement from? i do get the concept and may adopt it but just curious if there is a post somewhere

Actually @rvagg will tell you to always use readable stream to get the same stream interface regardless of your node version.

[thlorenz]

He advised me earlier about this, but actually he just blogged about it too.
https://twitter.com/rvagg/status/451511662470643712

[thlorenz]

After reading it again we might think about using '~1.0.0' instead of the one I pulled with.
That way we'd get the more stable stream2 version.

Either way should be fine though.

[ctalkington]

@thlorenz thanks. the one thing that is painful is lack of isStream, like when wanting to wrap older streams that are passed to your streams2 module.

[mafintosh]

@thlorenz We're using ~1.0.26-4 which should stable enough. The unstable one (streams3) is 1.1.0

[thlorenz]

@mafintosh got it, all good then :)