-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packing go binaries prevents entry callback from being called #64
Comments
could you share the binary file that is causing trouble? don't have go installed |
Sorry for the late reply. Here's a link to the binary that is not behaving: http://ipfs.io/ipfs/QmbWN6wpsuSwTrVNWX2nwGCM9ZqnPSzNYc3hUZACKANWiR |
Not sure if this has anything to do with a go binary, similar code hangs for me as well as soon as I'm trying to pipe a |
@mgcrea can you share a test case? |
I ran into this issue as well while trying to extract Go binaries from a tar archive I had created with tar-stream. Further tests showed other large files, such as Mac .dmg files, had the same problem. I did find a workaround, which I posted here: https://gist.github.com/diamondap/b6b36dd50e1e94e2bbe89a221124eb76 This issue does not seem to affect normal read streams, only PassThrough streams. All of the large binary files I tried to extract failed before this workaround, and they all work after. |
This is the strangest bug, but I've narrowed it down to go binaries. tar-stream seems to silently fail to add them. Anything else I add to the tar works fine.
Steps to reproduce:
Create file
test.go
:Build go file:
Create file
test.js
:Expected result:
This happens
gets logged and the pack is finalized.Actual result:
This happens
is never logged and pack is not finalizedThe text was updated successfully, but these errors were encountered: