New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use async_hooks #29
use async_hooks #29
Conversation
965aedf
to
8d83c1c
Compare
@mafintosh I know that you usually want to have support for many node versions, but iirc there has been some problems with this module due to differences in node implementations. In this case, moving up to node 8 to make it work better and also cleaner code is a good trade off. |
New major I guess 😉 |
@mafintosh cleaner, I like it |
2.0.0 |
This decision is not user friendly; the README doesn't state that Node 8 is required, there's no CHANGELOG or release notes, you don't have an I get wanting to use the latest technologies. Please find a balance by updating documentation (state in the README the version requirements and what to do if you don't have it), enforcement ( Example: Node 8 and above:
Earlier Node versions (no longer supported):
|
Feel free to send a PR :)
…On Thu, Feb 22, 2018, 19:16 Jon Peck ***@***.***> wrote:
This decision is not user friendly; the README doesn't state that Node 8
is required, there's no CHANGELOG or release notes, you don't have an
engines in your package.json that would have highlighted the problem, and
there's a lot of folks still on Node 6.
I get wanting to use the latest technologies. Please find a balance by
updating documentation (state in the README the version requirements and
what to do if you don't have it), enforcement (package.json engines), and
using release notes to declare why it's a major version.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAW_VQeDEw47QSe_buRi1izfwQ8o7M4yks5tXb0VgaJpZM4SFIrO>
.
|
Starred this three weeks ago, finally got around to it :-) |
Uses async_hooks to track the handles and stacks. Much, much cleaner but only supported by node >= 8 AFAIK (cc @andreas_madsen).
Thoughts @ralphtheninja @yoshuawuyts ?