Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This repo may be mis-reporting histogram references #58

Open
justinmchase opened this issue Mar 8, 2022 · 2 comments
Open

This repo may be mis-reporting histogram references #58

justinmchase opened this issue Mar 8, 2022 · 2 comments

Comments

@justinmchase
Copy link

This repo appears to be mis-reporting histogram.enable() as a lingering reference:

Related to siimon/prom-client#494

# ELDHISTOGRAM
node:internal/async_hooks:201                                                   
node:internal/perf/event_loop_delay:81                                          
node:internal/perf/event_loop_delay:78                                          
/var/app/example/node_modules/prom-client/lib/metrics/eventLoopLag.js:47 - const histogram = perf_hooks.monitorEventLoopDelay({
/var/app/example/node_modules/prom-client/lib/defaultMetrics.js:43       - metric(config.register, config);

This was reported upstream to nodejs nodejs/node#42132 and they concluded histograms should not be showing here since they are unref'd at the runtime level. Therefore we suspect that it may be a false positive here in this repo.

I see that you have a number of other types blocklisted here:

var hook = asyncHooks.createHook({
init (asyncId, type, triggerAsyncId, resource) {
if (type === 'TIMERWRAP' || type === 'PROMISE') return
if (type === 'PerformanceObserver' || type === 'RANDOMBYTESREQUEST') return

I'm wondering if histogram's should be added here as well?

@twpol
Copy link

twpol commented Apr 25, 2022

Might be fixed by #60?

@RaisinTen
Copy link
Contributor

#60 has just landed and it has been released in v2.2.2. Could you please check if this is still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants