Game board side-bar updates.

[lodici]

• merge user-action panel with player panel.
• improve signal-to-noise ratio in user-action panel by restricting to user-decision prompts only.
• suppress user-action panel if playing an AI vs AI game.
• position of the four side-bar components should be configurable.
• remove priority player from turn status panel. Inconsistent.
• display overall duel score in turn status panel.
• display duel target as tooltip (eg. "First player to win 4 games wins the duel.").
• display number of items in stack.

[lodici]

You can now re-arrange the components in the duel side-bar. No UI as yet but you can do it manually by adding or updating the following property in \Magarena\general.cfg -

duelSidebarLayout=LOGSTACK,PLAYER2,TURNINFO,PLAYER1

Simply move the order around to have it reflected in the display (restart required).

I have also made the above order the default order -

[lodici]

Added dialog to arrange side-bar components

[ShawnieBoy]

Nice

[lodici]

I have added a new setting to the gameplay preferences tab. Off by default, if enabled it will suppress the prompts in the user action panel unless a decision is required by you. I find this a big improvement on the signal-to-noise ratio not least of which is the removal of the prompt that tells you what the AI is going to play about 5 seconds before it plays it..

I could not come up with a particularly elegant solution, requiring lots of &&ing and ||ing, (see isUserActionPromptHidden in SwingGameController) so if you know of a better way please update.

I have played quite extensively with this setting enabled and so far it seems to be working as expected but there is no substitute for more people testing so please give it a go and let me know what you think. My intention is to release it ON by default in 1.61 and if there are no major objections remove it as a setting in 1.62.

[melvinzhang]

The reason AI message are shown is due to the showMessage call in getArtificialNextEventChoiceResults. I've added a check with getHideAiActionPrompt before calling showMessage.

[melvinzhang]

Btw, why does clearUserAction prompt have the condition (game.getPhase().getType() != MagicPhaseType.DeclareAttackers) ?

[melvinzhang]

I think I see it, you have to avoid DeclareAttackers because otherwise after choosing the first attacker the message is removed. I think the MagicChoices were not designed with the message being cleared after the first response. We can get the same effect without the awkward check by clearing the user action prompt when it is the AI's decision. Implemented in e23debb

[melvinzhang]

The final implementation is simpler: if hide AI choices is true, during AI's choice show an empty message to clear the user action prompt, otherwise show the actual message.