Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to language specific version of Keywords.txt if available. #417

Closed
lodici opened this issue Aug 3, 2015 · 6 comments
Closed

Point to language specific version of Keywords.txt if available. #417

lodici opened this issue Aug 3, 2015 · 6 comments

Comments

@lodici
Copy link
Member

lodici commented Aug 3, 2015

There is now a russian translation available in the forums.

@PalladiaMors
Copy link
Contributor

I've downloaded the latest build and tried to find the keywords file in order to translate it, but couldn't locate it in the Magarena folder. The file in the forums is in Russian which unfortunately isn't one of my greatest skills (well I confess I've tried to sing the Katyusha on occasion and found out that's a pretty good way to evacuate a room, for some reason). Where can I find the file in English?

@lodici
Copy link
Member Author

lodici commented Aug 4, 2015

Good point. The keywords.txt file is currently built into the jar file which means you need access to the source code.

To make translation easier and with an eye on future work I think it might be useful to update the translations folder to contain sub-folders for each translation - translations\Português, translations\Русский, etc. The folder name is used in the 'language' selector and the folder itself contains the UI strings file and optionally a keywords.txt file that overrides the default.

@lodici
Copy link
Member Author

lodici commented Aug 4, 2015

I decided to go for the easy option and just slightly tweak the existing code. The keyword files are still stored in the jar but have now been given their own resources folder. Simply add the translated file with exactly the same name as the file used in the translations folder to override the default English version. If no <language>.txt keywords file exists (or it is misspelt!) then it defaults to using English.txt.

@PalladiaMors
Copy link
Contributor

Not sure if this is the proper place to mention this, but the build queue has been stuck for over three days...

@lodici
Copy link
Member Author

lodici commented Aug 6, 2015

I sent them a message and they have raised an issue. - they don't seem to be aware that there is a problem.

@lodici
Copy link
Member Author

lodici commented Aug 18, 2015

Implemented (and Jenkins have also sorted themselves out as well!).

@lodici lodici closed this as completed Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants