Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring Nightmare should not be able to return creature sacrificed as cost #573

Open
melvinzhang opened this issue Dec 19, 2015 · 3 comments

Comments

@melvinzhang
Copy link
Contributor

reported by sponeta at http://www.slightlymagic.net/forum/viewtopic.php?f=82&t=17929#p190028

test case: TestRecurringNightmare.java

bug is due to different order of actions of Magarena vs MTG. In Magarena, we pay costs first, then choose target. In MTG, choose target occurs before paying costs.

@melvinzhang
Copy link
Contributor Author

@melvinzhang
Copy link
Contributor Author

The main difficulty with changing the order is that some effects depends on the cost when they go on the stack, eg {X}: Deal X damage to target creature.

The value X is stored in the MagicCardOnStack that is put on the stack, if the costs are paid after the effect goes on the stack, we will need a new way to update the stack with the value of X. Methods that require a payedCost to return an event would have to be modified.

@melvinzhang
Copy link
Contributor Author

Alternatively we just fix only Recurring Nightmare by using groovy code to prevent it from selecting the sacrificed creature as a target of its effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants