Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For WFS endpoint, we should always apply a maxFeatures to GetFeature requests #18

Open
t83714 opened this issue Nov 5, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@t83714
Copy link

t83714 commented Nov 5, 2021

Background

We have this WFS dataset that doesn't work on magda map preview

https://data.gov.au/geoserver/manningham-maternal-and-child-health-centres/wfs?service=WFS&version=1.1.0&request=GetCapabilities

The reason is the GetFeature request below

https://data.gov.au/geoserver/manningham-maternal-and-child-health-centres/wfs?service=WFS&request=GetFeature&typeName=manningham-maternal-and-child-health-centres%3Ackan_37dda99d_83d9_4261_8c5d_c70a5d38cc86&version=1.1.0&outputFormat=JSON&srsName=EPSG%3A4326

will trigger around 2GB download.

Solution

Background

We have this WFS dataset that doesn't work on any TerriaJS map:

https://data.gov.au/dataset/ds-dga-7ded7c00-475a-4c54-aaa6-6b4538eb28ef/distribution/dist-dga-759053f2-7597-4997-84ff-f722af4ca660/details

https://data.gov.au/geoserver/manningham-maternal-and-child-health-centres/wfs?service=WFS&version=1.1.0&request=GetCapabilities

The reason is the GetFeature request below

https://data.gov.au/geoserver/manningham-maternal-and-child-health-centres/wfs?service=WFS&request=GetFeature&typeName=manningham-maternal-and-child-health-centres%3Ackan_37dda99d_83d9_4261_8c5d_c70a5d38cc86&version=1.1.0&outputFormat=JSON&srsName=EPSG%3A4326

will trigger around 2GB download.

Solution

We should always apply a maxFeatures query parameter to GetFeature requests that terriaJS send out.

Currently, latest v8 terriaJS already auto-add maxFeatures query parameter to GetFeature requests.

As we still using an earlier version of terriaJS for map preview, we probably have two options to fix the issue:

  • Upgrade to latest terria map v8. We will need to fix the CI release issue as Magda preview is released via CI at this moment.
  • Apply the fix on a current version TerriaJs fork.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant