Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .gitignore excluded by default from new mirror versions #144

Open
Vinai opened this issue Oct 10, 2023 · 0 comments
Open

Make .gitignore excluded by default from new mirror versions #144

Vinai opened this issue Oct 10, 2023 · 0 comments
Assignees

Comments

@Vinai
Copy link
Contributor

Vinai commented Oct 10, 2023

Currently the Magento Open Source releases that don't include a .gitignore file in the project root are listed in an array in src/build-config/packages-config.js:

const releasesWithoutGitIgnore = ['2.4.1', '2.4.1-p1', '2.4.2', '2.4.4-p3', '2.4.4-p4', '2.4.4-p5', '2.4.4-p6', '2.4.5-p2', '2.4.5-p3', '2.4.5-p4', '2.4.5-p5', '2.4.6', '2.4.6-p1', '2.4.6-p2', '2.4.6-p3'];

However, new upstream releases all seem to exclude the .gitignore, so the array needs to be updated with the new versions for each new release.

This is error prone and has slowed down adding new releases to the mage-os mirror repo several times in the past.
The default should be changed to a list of releases that include a .gitignore instead.

@Vinai Vinai self-assigned this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant