Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varnish support #6

Closed
Tjitse-E opened this issue Apr 25, 2019 · 3 comments
Closed

Varnish support #6

Tjitse-E opened this issue Apr 25, 2019 · 3 comments

Comments

@Tjitse-E
Copy link

Does this module work with Varnish caching enabled?

@magefan
Copy link
Owner

magefan commented Apr 25, 2019

@Tjitse-E , thank you for your question. This module is not a self-sufficient module, it is pease of code that works with different GeoIp databases and provides the functionality to define visitor country based on the IP (GeoLocation). If you want to get an answer I this module works with Varnish, the answer depends on how you will use it.

We use magefan/module-geoip in these our modules

  1. Magento 2 Auto Currency Switcher Extension
  2. Magento 2 Auto Language Switcher Extension

both of these auto-switcher extensions compatible (work) with varnish.

Let us know if you have any other questions.

@Tjitse-E
Copy link
Author

Hi @magefan.

We've created a auto country select module on top of Magefan GeoIP. I'll test in the coming weeks if it will work with Varnish.

Thanks for the module so far!

@magefan
Copy link
Owner

magefan commented Apr 29, 2019

@Tjitse-E , We have checked the code of your module (vendic/magento2-geoip-country-preselect), and it will have an issue with Magento Page Cache and will not work properly with varnish. We recommend to use Magento 2 Auto Currency Switcher by Magefan. It already does what you trying to achieve, and works perfectly with Magento build in Page Cache and Varnish, it will allow you to save time and money.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants