Skip to content
This repository has been archived by the owner on Jun 19, 2018. It is now read-only.

Make a fallback view for when URL resolution fails or times out #41

Closed
zetlen opened this issue May 26, 2018 · 1 comment
Closed

Make a fallback view for when URL resolution fails or times out #41

zetlen opened this issue May 26, 2018 · 1 comment

Comments

@zetlen
Copy link
Contributor

zetlen commented May 26, 2018

This issue is a:

[ ] Bug
[x] Feature suggestion
[ ] Other

Description:

If GraphQL isn't working, or returns null for the MagentoRouter URL resolution call, then the Loading screen displays forever. It should switch to an error.

Environment and steps to reproduce

OS: Any

Magento 2 version: Any

Other environment information:

Steps to reproduce:

  1. Configure a PWA with Peregrine, Buildpack, and a Magento 2 store.
  2. Launch the development server with npm start.
  3. Navigate to a known-nonexistent URL.
  4. Observe the loading screen stays forever.

Expected result:

Loading screen is replaced with an informative error screen.

Possible solutions:

  • Response to specific GraphQL states
  • Variant of Loading screen
  • Specified timeout

Additional information:

  • Consider developer mode and production mode versions of this
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants