Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

September 11, 2019 #265

Closed
paliarush opened this issue Sep 6, 2019 · 7 comments
Closed

September 11, 2019 #265

paliarush opened this issue Sep 6, 2019 · 7 comments
Labels
meeting notes Topic requests and notes from meetings

Comments

@paliarush
Copy link
Contributor

paliarush commented Sep 6, 2019

Please add your topic as a comment to the issue. Use following format:
Topic description and link to PR, if any (duration in min)

Time: 10:30am CST/CDT

BlueJeans Meeting - https://bluejeans.com/7385677850

馃帴 Recording

@paliarush paliarush added the meeting notes Topic requests and notes from meetings label Sep 6, 2019
@paliarush
Copy link
Contributor Author

Versioning in GraphQL: #263 (5-10 min)

@lenaorobei
Copy link
Contributor

Single mutation for adding products to cart + wishlist #256 (10 min)

@buskamuza
Copy link
Contributor

Code style for GraphQL schema (#269) (5min)

@arhiopterecs
Copy link

Reduce q-ty of error reports created in <magento_root>/var/report #271(10 min)

@prabhuram93
Copy link
Contributor

Graphql product filters #272 (10 - 15 min)

@melnikovi
Copy link
Member

melnikovi commented Sep 11, 2019

Database compatibility for declarative schema #264 (15 min)

Note: didn't have time for this item. To be moved to the next meeting.

@buskamuza
Copy link
Contributor

  • Versioning in GraphQL
    • @paliarush : we may go back to original (non-versioned name later, e.g. in 5 years)
    • Add more details, to make the rules clear for fields, types, etc.
  • Single mutation for adding products to cart + wishlist
    • @irenelagno : does it support "file" as an option? @akaplya : yes, as entered option.
    • @buskamuza : why do we need base64_encode? @akaplya : it's just an id, in the future it can be replaced with UUID. Client can get list of option ids with labels from the server
    • @kandy : can we add signature to ids? @akaplya , probably we can, we can look at this in the next iteration.
  • Reduce q-ty of error reports created in <magento_root>/var/report
    • Add recommendations, which we can convert to guidelines
    • Consider lightweight DB as a storage
    • Consider logging everything in one file?
  • Graphql product filters
    • @paliarush : it will not solve the cache regeneration problem entirely because the attributes are necessary for displaying the product
    • Add a real scenario to go through and understand which queries are necessary. Possible scenarios are: product listing page with layered navigation, product page.
    • There is still a problem with many attributes "spoiling" the schema on the top level
    • @paliarush : include metadata in aggregations response looks useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting notes Topic requests and notes from meetings
Projects
None yet
Development

No branches or pull requests

6 participants