Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Introduce mock for USPS shipping testing #739

Closed
lenaorobei opened this issue Jun 13, 2019 · 1 comment
Closed

Introduce mock for USPS shipping testing #739

lenaorobei opened this issue Jun 13, 2019 · 1 comment
Assignees
Projects

Comments

@lenaorobei
Copy link
Contributor

lenaorobei commented Jun 13, 2019

Description (*)

Instead of real calls to the carrier service we need to introduce mock object that will return expected info.

Additional information

  1. Introduce new test module under dev/tests/api-functional/_files/Magento.
  2. Module will serve for other carriers as well.
  3. Declare preference in di.xml for Magento\Usps\Model\Carrier.
  4. Instead of real call to the gateway, return expected info.
  5. Undo skipped tests Magento\GraphQl\Usps\SetUspsShippingMethodsOnCartTest [Shipping methods] Test coverage of USPS shipping method #662.
@m2-community-project m2-community-project bot added this to Dev In Progress in Backlog Jun 13, 2019
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Grooming in Backlog Jun 13, 2019
@naydav naydav moved this from Ready for Grooming to Ready for Development in Backlog Jun 13, 2019
@pmclain pmclain self-assigned this Jun 16, 2019
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in Backlog Jun 16, 2019
@pmclain pmclain mentioned this issue Jun 22, 2019
4 tasks
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in Backlog Jun 22, 2019
@naydav naydav closed this as completed Jul 10, 2019
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Backlog Jul 10, 2019
@naydav
Copy link
Contributor

naydav commented Jul 11, 2019

#753

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Backlog
  
Done
Development

No branches or pull requests

3 participants