Bug: MFTF does not close connection to Selenium hub

[lbajsarowicz]

While everything works as expected when running standalone instance of Selenium, when running Selenium hub repeatedly - the browser instances are not being freed up.

Preconditions

1. Start selenium hub and 3 instances of selenium chrome assigned to the hub

Steps to reproduce

1. Run any suite and wait till it's done
2. Try to run the suite again

Expected result

1. Suite is being performed

Actual result

1. MFTF reports that it cannot connect to selenium hub
   

[lbajsarowicz]

Having 3 instances of Selenium Chrome and running single test, I end up with $ curl http://selenium-hub:4444/wd/hub/status returning

{
  "status": 0,
  "value": {
    "ready": false,
    "message": "No spare hub capacity",
    "build": {
      "revision": "e82be7d358",
      "time": "2018-11-14T08:25:53",
      "version": "3.141.59"
    },
    "os": {
      "arch": "amd64",
      "name": "Linux",
      "version": "5.3.0-40-generic"
    },
    "java": {
      "version": "1.8.0_242"
    }
  }

Selenium Hub restart helps:

{
  "status": 0,
  "value": {
    "ready": true,
    "message": "Hub has capacity",
    "build": {
      "revision": "e82be7d358",
      "time": "2018-11-14T08:25:53",
      "version": "3.141.59"
    },
    "os": {
      "arch": "amd64",
      "name": "Linux",
      "version": "5.3.0-40-generic"
    },
    "java": {
      "version": "1.8.0_242"
    }
  }
}

[lbajsarowicz]

That might be a hint: elgalu/docker-selenium#296

[jilu1]

@lbajsarowicz This issue might have been fixed. Can you please try this with MFTF 3.0.0?

[lbajsarowicz]

@jilu1 Verifying that now.

[lbajsarowicz]

@jilu1 Looks like it was fixed. Could you tell me which PR fixed that?

[jilu1]

@jilu1 Looks like it was fixed. Could you tell me which PR fixed that?

It's fixed as part of 3.0.0.