-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with JS after update to 2.11.0 #161
Comments
Hey @SerhiiMandrykin, thanks for reporting the issue! |
Hi, here having this Then it complained about lib/web/jquery/jquery.storageapi.min.js too, which seems defined in vendor/magento/module-theme/view/base/requirejs-config.js Btw using Magento 2.4.2-p1 and latest Magepack 2.11.0, the issue not happening when using Magepack 2.10.1 |
I've tracked this down to the changes introduced in #142 and minified content. The example I've found is from moment:
Version 2.8.0 identifies this as an AMD module and names it, but version 2.11.0 doesn't identify this as an AMD module, so wraps it, leading to the duplicate |
Nice, that's a downside of trying to parse code with regular expressions 😄 That said, the more corner cases we find, the more tests we'll have and we should be safer in the future. |
Yes, I've written the test first this time. :) |
After updating our magepack to the version 2.11.0 we were facing the error like:
After rolling back to 2.10.1 the error has gone.
The text was updated successfully, but these errors were encountered: