armv7l build support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to add armv7 support, a few files must be changed slightly to change the assumed availability of SSE2 instructions.
To make things simple, changes are made in the Qt makefile and the standard makefile - this allows hand-off compilation to anyone compiling the source, as the only real change is that the headless ARM version requires the xCPUARCH=armv7l command-line argument in addition to the standard UNIX build arguments.
I've also merged all the building instructions into the original UNIX build files, mostly because my original solution of creating a new file specifically for ARM builds was helpful to me, but I believe that it would be unhelpful in a release setting.
Please review these changes and let me know if you'd like me to clean anything up or style it in a particular way.
Edit: the most recent change, 35796f7, fixed Raspberry Pi 2 compatibility (I think), based on the experience of someone that emailed me. It removes the flag I set that forced thumb instruction mode because the RPi2 processor doesn't support the full range of hard-float math operations used by the wallet in thumb. Which is fine, I suppose, because it speeds up the wallet binary.