Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Method Warning when pushing pod with dependency on 2.3 in Xcode #1090

Open
AnthonyMDev opened this issue Sep 17, 2015 · 7 comments
Labels
Milestone

Comments

@AnthonyMDev
Copy link
Contributor

I've pushed pods many times that depended on 2.3 in the past, but after installing Xcode 7, when I try a pod repo push for a pod spec with a dependency on MagicalRecord, I get the following warnings.

    - WARN  |  MagicalRecord/MagicalRecord/Categories/NSManagedObject/NSManagedObject+MagicalRecord.m:246:21: warning: 'MR_deleteInContext:' is deprecated: This method has been deprecated and will be removed in MagicalRecord 4.0. Please use `MR_deleteEntityInContext:` instead. [-Wdeprecated-declarations]
    - NOTE  |  MagicalRecord/MagicalRecord/Categories/NSManagedObject/NSManagedObject+MagicalRecord.h:72:1: note: 'MR_deleteInContext:' has been explicitly marked deprecated here

The spec does not validate.

I am able to push the repository using the --allow-warnings flag, but this doesn't seem ideal.

I know 2.3.0 was supposed to be the last release until 3.0, but you might want to consider a patch version 2.3.1 for this. I'd be happy to make a pull request to solve the issue if you will release a 2.3.1.

@tonyarnold
Copy link
Contributor

Hey @AnthonyMDev by all means, a pull request would be great. I'm not averse to the idea of releasing a 2.3.1 update.

@AnthonyMDev
Copy link
Contributor Author

@tonyarnold Thanks for the response.
PR #1091 fixes the issue.
I'd love to see a 2.3.1 ASAP!

@tonyarnold
Copy link
Contributor

I'm all for a new release, but I'm travelling with work until tomorrow (and I haven't seen my kids/wife in a week) so it might be a day or two if I don't get it sorted this morning. There's a failing test in the project that I'm trying to track down and fix (you're welcome to have a look at TravisCI and see why builds are failing if you have time!).

@AnthonyMDev
Copy link
Contributor Author

@tonyarnold
Thank you!
I'll see what I can find out. If I can't figure it out, then I will patiently await your release. Enjoy spending some time with your wife and kids.

@AnthonyMDev
Copy link
Contributor Author

I'm not super familiar with either Circle CI or Travis CI unfortunately. It looks like for both of them that there is something wrong with your configuration though.

Circle CI is trying to build the OS X target on the iPhone 6 simulator, which is causing the failure there.

Travis is failing a number of tests on the iPhone 4s simulator, but all of the tests are passing for me when I run them in Xcode on an iPhone 4s simulator. My bet would be that Travis CI is using an old, deprecated SDK version or something, but I'm not really familiar enough with it to say more.

I might be able to debug this a bit more, but I don't have access to your test machines, so I can't really run the CI tests at will.

Hope you can sort this out soon. Good luck.

@AnthonyMDev
Copy link
Contributor Author

@tonyarnold Any word on getting a 2.3.1 release soon? It still looks like your CI is just broken in general. It shouldn't have anything to do with PR #1091 as PR #1088 is failing checks and all it does it edit the Podfile.

@tonyarnold
Copy link
Contributor

Sorry, I've been swamped since I got home — CI isn't broken, per se — we have a failing test in there that only fails when it's run on the CI servers. Really annoying, and not easy to replicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants