Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Interactive map for CQ Award #1650

Closed
kb-light opened this issue Oct 7, 2022 · 25 comments
Closed

[Feature] Interactive map for CQ Award #1650

kb-light opened this issue Oct 7, 2022 · 25 comments
Labels
Feature This would improve Cloudlog Help Wanted While I could code it myself, would like some help. In Development This is currently being added

Comments

@kb-light
Copy link
Contributor

kb-light commented Oct 7, 2022

I like the map which is shown at the Worked All States award page and I would like to have a similar map for the CQ Award. Also for DXCC and so on, but that seems a bit much to me.

Additionally the "Map" subpage at CQ Award can then be removed.

@AndreasK79
Copy link
Contributor

I wouldn't mind implementing it, if you could find an interactive javascript map for CQ zones or DXCC, like the one made for the US States.

@magicbug magicbug added Feature This would improve Cloudlog Help Wanted While I could code it myself, would like some help. labels Oct 7, 2022
@AndreasK79
Copy link
Contributor

Perhaps something like this could work:

image
I need to solve a problem with zone 1, 19, 31 and 32. They will not draw correctly in Leaflet.

@magicbug
Copy link
Owner

magicbug commented Oct 8, 2022

That would work.. @g7vjr did have some KML files for CQ and ITU zones but seems blogs down

@AndreasK79
Copy link
Contributor

Yep, that was my first idea (IV3TMM links them on his QRZ profile).
image
Same problem with the zones.

The problem is Leaflet:
Leaflet/Leaflet#82

@AndreasK79
Copy link
Contributor

Tried to solve it with the antimeridian plugin, but the result wasn't exactly what I wanted.
image
Not sure if I can manage to solve this one, but haven't given up quite yet.

@phl0
Copy link
Contributor

phl0 commented Oct 9, 2022

Well at least it looks ... "interesting" ... :)

@AndreasK79
Copy link
Contributor

Haha. Yes, that is one way of describing it :)

@AndreasK79
Copy link
Contributor

Now we're getting somewhere:

image

@AndreasK79
Copy link
Contributor

The worst part is done:
image

@magicbug
Copy link
Owner

magicbug commented Oct 9, 2022

What's the best part

@AndreasK79
Copy link
Contributor

Integrating it into Cloudlog. That should just be a matter of doing now that the zones are drawn correctly :)

@phl0
Copy link
Contributor

phl0 commented Oct 9, 2022

Great job @AndreasK79 👍

@ghost
Copy link

ghost commented Oct 11, 2022 via email

@AndreasK79
Copy link
Contributor

Great job @AndreasK79 👍

Thanks

@AndreasK79
Copy link
Contributor

Fantastic work on this! 🙌

Thanks Michael.

A few things left to do, but shouldn't be that hard:
image

Perhaps you are interested in the map for Club Log as well?

@AndreasK79
Copy link
Contributor

Another teaser:
image
Some polishing and tweaking, but getting there.

Also need to add popup with QSOs when clicking on map.

@magicbug
Copy link
Owner

This is looking swish!

@phl0
Copy link
Contributor

phl0 commented Oct 11, 2022

Want++. Nice work @AndreasK79

@magicbug
Copy link
Owner

Should I hold out to put it in V2 launch ;-)

@AndreasK79
Copy link
Contributor

It depends on how eager you are to release.

Hopefully I can make a PR tomorrow afternoon for testing.

@magicbug magicbug added the In Development This is currently being added label Oct 11, 2022
@magicbug
Copy link
Owner

Its taken this long to get it ready.. another day wont hurt

@AndreasK79
Copy link
Contributor

Test away :)

@kb-light
Copy link
Contributor Author

kb-light commented Oct 12, 2022

image
Thanks, that was faster than expected (when adding this feature request) and it looks great.

Bug:

  • Old maps seems to stay in the background. You can see that when generating multiple maps and than zoom out or try to move the map.

Some small improvements:

  • Add a small space between the map and the Bottom of the screen (similar to the tables)
    • EDIT: seems related to screen size/zoom level
  • Shift the map a bit to the right as there are small parts missing from zone 31 and 32

@AndreasK79
Copy link
Contributor

The map is responsive, so there will always be space between the map and the bottom.
We can shift the map a bit to the right, but the whole map will not fit. If you use a widescreen monitor, take a look at these custom wide themes I made: https://github.com/AndreasK79/cloudlog_wide_custom_themes

As for the old maps, I need to see if I can figure out what's going on.

@phl0
Copy link
Contributor

phl0 commented Oct 12, 2022

Confirmed. Seems like pushing the button again just creates a new map overlay (which is hidden below the first one)

Screenshot from 2022-10-12 21-42-08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This would improve Cloudlog Help Wanted While I could code it myself, would like some help. In Development This is currently being added
Projects
None yet
Development

No branches or pull requests

4 participants