Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enlarge COL_MODE from varchar(10) to varchar(12) #359

Closed
dg9vh opened this issue Oct 5, 2019 · 3 comments
Closed

enlarge COL_MODE from varchar(10) to varchar(12) #359

dg9vh opened this issue Oct 5, 2019 · 3 comments

Comments

@dg9vh
Copy link
Contributor

dg9vh commented Oct 5, 2019

If you take a look at http://www.adif.org/304/ADIF_304.htm#Mode_Enumeration you'll see, that "DIGITALVOICE" is a valid mode in ADIF-Specification with length of 12 chars, COL_MODE only allows varchar(10), so we need 2 additional characters there to produce valid logs in ADIF.

@magicbug
Copy link
Owner

magicbug commented Oct 5, 2019

Oddly I hit that issue today I just made a change request on the PR sir once change is done i'll add it.

You might need to add similar for sub_mode

@magicbug
Copy link
Owner

magicbug commented Oct 5, 2019

@dg9vh Kim Thanks its now merged :) do you think COL_SUB_MODE needs similar?

@magicbug
Copy link
Owner

magicbug commented Oct 5, 2019

Submodes 25 so should be fine! closing this issue

@magicbug magicbug closed this as completed Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants