Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocket 0.5.0-dev with multipart-async #9

Open
arnodb opened this issue Nov 2, 2020 · 3 comments
Open

Rocket 0.5.0-dev with multipart-async #9

arnodb opened this issue Nov 2, 2020 · 3 comments

Comments

@arnodb
Copy link

arnodb commented Nov 2, 2020

Hi,

I've just spent some time making rocket-multipart-form-data compile against rocket's master branch: https://github.com/impero-com/rocket-multipart-form-data/tree/rocket-0.5.

The example actually does not compile because I didn't have the time to fix rocket-etag-if-none-match where I faced with a problem with hyper. However, I have quickly tested the whole thing with one use case and it seems to be working.

If you are interested in moving forward with this, I would be keen to do additional work.

@magiclen
Copy link
Owner

magiclen commented Apr 28, 2021

I replaced the multipart crate with multer and upgrade Rocket to 0.5.0-dev. The example can be compiled and works fine.

0a175cc

@SergioBenitez
Copy link

SergioBenitez commented May 5, 2021

Note that 0.5 already includes direct support for multipart forms. See FromForm and the master forms guide.

@magiclen
Copy link
Owner

magiclen commented May 8, 2021

I wrote another example which uses a struct to derive FromForm to try to do the same things that this example does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants