Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'not' keyword isn't being highlighted in Atom #19

Closed
austincrft opened this issue Oct 24, 2015 · 5 comments
Closed

'not' keyword isn't being highlighted in Atom #19

austincrft opened this issue Oct 24, 2015 · 5 comments
Labels

Comments

@austincrft
Copy link

Default Python syntax:
image

MagicPython syntax:
image

@1st1
Copy link
Member

1st1 commented Oct 24, 2015

Can't reproduce. Could you please provide about 10 lines of code before/after those lines?

What color theme are you using?

@austincrft
Copy link
Author

I imagine that it has to do with the syntax theme because it is happening elsewhere in my code. Here's the info:

Syntax theme:
solarized-dark-syntax

Lines above

def mailing_list_preferences_test():
    email = 'abc@123.com'
    user = User.query.filter_by(email=email).first_or_404()
    form = MailingListForm()

    # Don't fill fields on form submit
    if not form.validate_on_submit():
        form.fill_fields_with_user(user)

@austincrft
Copy link
Author

Just tried it on the other syntax themes that ship with Atom. None of them highlighted the case I gave you just now, but solarized-light-syntax and atom-light-syntax highlighted some of the not keywords properly

@1st1 1st1 added the bug label Oct 24, 2015
@1st1
Copy link
Member

1st1 commented Oct 24, 2015

Should be fixed in v0.4.34. Please update.

(See for details 9f7e839 and d78bdaa)

Thanks a lot for discovering this!

@1st1 1st1 closed this as completed Oct 24, 2015
@austincrft
Copy link
Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants