Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for newline between function parameters and return type #51

Closed
alexjurkiewicz opened this issue Aug 9, 2016 · 4 comments
Closed

Comments

@alexjurkiewicz
Copy link

  • Editor name and version: Atom 1.9.3
  • MagicPython version: MagicPython 0.5.13
  • A sreenshot:
    screen shot 2016-08-09 at 2 22 16 pm
  • 5-10 lines of surrounding code:
@util.timer
def get_streaks(s: sqlalchemy.orm.session.Session,
                active: Optional[bool]=None,
                sort_by_length: Optional[bool] = False,
                limit: Optional[int]=None,
                ) \
        -> Sequence[Streak]:

Python runs this code just fine, it seems MagicPython doesn't handle newline continuations in this space properly. Removing the \ has no effect on syntax highlighting.

@alexjurkiewicz alexjurkiewicz changed the title No support for newline between function parameter and return type No support for newline between function parameters and return type Aug 9, 2016
@1st1
Copy link
Member

1st1 commented Aug 9, 2016

Should be fixed in v0.5.14.

@1st1
Copy link
Member

1st1 commented Aug 9, 2016

Thanks for reporting this!

@alexjurkiewicz
Copy link
Author

Wow, thanks for the speedy fix!! Love this project :)

On Tue, 9 Aug 2016, 2:41 PM Yury Selivanov notifications@github.com wrote:

Thanks for reporting this!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#51 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXKdfCkcGPnMEgG7GYeRcwjf5TfHwIgks5qeAUBgaJpZM4JftBM
.

@1st1
Copy link
Member

1st1 commented Aug 9, 2016

Closing this issue. Please reopen if it's not resolved.

@1st1 1st1 closed this as completed Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants