Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The draw API draws edges and nodes incorrectly when more than one SVG exists in the document #47

Closed
magjac opened this issue Apr 8, 2018 · 2 comments
Assignees
Labels

Comments

@magjac
Copy link
Owner

magjac commented Apr 8, 2018

A drawn edge or node is drawn on the first SVG in the document, which is not necessarily the SVG rendered by d3-graphviz. When the edge or node is inserted into the graph, d3-graphviz renders it correctly, but it is still visible on the first SVG, at least partly.

Note that this bug affects the draw API only. Graphs are still rendered correctly from DOT source.

@magjac
Copy link
Owner Author

magjac commented Apr 8, 2018

Partial fixes are implemented in 84eae0d and dc02e7f, which makes the edges and nodes being drawn on the correct SVG, but with an offset to the given coordinates.

@magjac
Copy link
Owner Author

magjac commented Apr 8, 2018

The offset problem wasn't a problem with the draw API, but only with the examples. The examples have been updated with d0b3b1f and a new example with multiple SVG's has been added with 09cc69d.

@magjac magjac closed this as completed Apr 8, 2018
@magjac magjac self-assigned this Apr 8, 2018
@magjac magjac added the bug label Apr 8, 2018
@magjac magjac changed the title The draw API draws edges and nodes incorrectly when more than one SVG exist in the document The draw API draws edges and nodes incorrectly when more than one SVG exists in the document Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant