Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error indication in text editor is cleared even though the error is still present #33

Closed
magjac opened this issue Sep 13, 2018 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@magjac
Copy link
Owner

magjac commented Sep 13, 2018

If neither the error message nor the line number changes when the DOT source is edited, the error indication is removed, although the error is still present.

A workaround is to add or delete a line in the beginning of the DOT source, which forces the line number to change.

The reason for this bug seems to be that the Ace editor clears the annotations internally and the React Ace Component does not update them if they are not changed, see the source code.

@magjac magjac added the bug Something isn't working label Sep 13, 2018
@magjac magjac self-assigned this Sep 13, 2018
@magjac
Copy link
Owner Author

magjac commented Sep 13, 2018

Related to securingsincity/react-ace#129?

@magjac
Copy link
Owner Author

magjac commented Sep 13, 2018

The incorrect clearing seems to be initiated only when pressing the enter key on the line where the error is.

The workaround suggested in https://stackoverflow.com/questions/25903709/ace-editors-setannotations-wont-stay-permanent does not work.

@magjac magjac closed this as completed in b785528 Sep 13, 2018
Graphviz Visual Editor short-term activities automation moved this from In progress to Done Sep 13, 2018
@magjac
Copy link
Owner Author

magjac commented Sep 13, 2018

The implemented fix does not prohibit the incorrect clearing to occur, but the error indication is brought back almost immediately (after the user-configurable editor hold-off time).

@magjac magjac assigned magjac and unassigned magjac Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Graphviz Visual Editor short-term act...
  
Done but not yet merged
Development

No branches or pull requests

1 participant