Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting missing ext-random an PHP 8.2 #364

Closed
rieschl opened this issue Dec 7, 2022 · 5 comments
Closed

Reporting missing ext-random an PHP 8.2 #364

rieschl opened this issue Dec 7, 2022 · 5 comments
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement
Milestone

Comments

@rieschl
Copy link
Contributor

rieschl commented Dec 7, 2022

I just tried running the CI on PHP 8.2 (RC7) on one of our repositories and the require checker reported following:

> vendor/bin/composer-require-checker --config-file=composer-require-checker.json
ComposerRequireChecker 4.3.0@194cf647357b7077c63eee84653df2b0655b8845
The following 1 unknown symbols were found:
+----------------+--------------------+
| Unknown Symbol | Guessed Dependency |
+----------------+--------------------+
| random_int     | ext-random         |
+----------------+--------------------+

While technically this is correct, because 8.2 introduced a new ext-random extension for all the random stuff, the extension is bundled with php and cannot be disabled. So it seems to be useless to add ext-random to the require section of the composer.json file.

Should ext-random be whitelisted automatically?

Thanks for your help!

@Ocramius Ocramius added enhancement dependencies Pull requests that update a dependency file labels Dec 7, 2022
@Ocramius Ocramius added this to the 3.3.2 milestone Dec 7, 2022
@Ocramius
Copy link
Collaborator

Ocramius commented Dec 7, 2022

Feel free to send a patch alike #351 👍

@rieschl
Copy link
Contributor Author

rieschl commented Dec 12, 2022

@Ocramius is targeting 3.3.2 correct? This branch is over a year old. Did you mean 4.3.1 🙂

@Ocramius Ocramius modified the milestones: 3.3.2, 4.3.1 Dec 12, 2022
@Ocramius
Copy link
Collaborator

Good catch 😁

@Ocramius Ocramius modified the milestones: 4.3.1, 4.4.0 Dec 12, 2022
@rieschl
Copy link
Contributor Author

rieschl commented Dec 12, 2022

meh, maybe we should wait until PHP 8.2.1. ReflectionExtension does not recognize random in PHP 8.2.0 (Extension "random" does not exist) 🙄

@Ocramius
Copy link
Collaborator

Handled in #367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

No branches or pull requests

2 participants