PHP Fatal error with symfony/framework-bundle and traits

[Adirelle]

I have got this error with master.

composer-require-checker check composer.json 
ComposerRequireChecker 0.1.6-27-ga1b1407
PHP Fatal error:  Uncaught TypeError: Argument 1 passed to ComposerRequireChecker\NodeVisitor\UsedSymbolCollector::recordUsageOf() must be an instance of PhpParser\Node\Name, null given, called in /home/user/.composer/vendor/maglnet/composer-require-checker/src/ComposerRequireChecker/NodeVisitor/UsedSymbolCollector.php on line 153 and defined in /home/user/.composer/vendor/maglnet/composer-require-checker/src/ComposerRequireChecker/NodeVisitor/UsedSymbolCollector.php:166
Stack trace:
#0 /home/user/.composer/vendor/maglnet/composer-require-checker/src/ComposerRequireChecker/NodeVisitor/UsedSymbolCollector.php(153): ComposerRequireChecker\NodeVisitor\UsedSymbolCollector->recordUsageOf(NULL)
#1 /home/user/.composer/vendor/maglnet/composer-require-checker/src/ComposerRequireChecker/NodeVisitor/UsedSymbolCollector.php(50): ComposerRequireChecker\NodeVisitor\UsedSymbolCollector->recordTraitUsage(Object(PhpParser\Node\Stmt\TraitUse))
#2 /home/user/.composer/vendor/nikic in /home/user/.composer/vendor/maglnet/composer-require-checker/src/ComposerRequireChecker/NodeVisitor/UsedSymbolCollector.php on line 166

PHP Version:

php -v
PHP 7.1.11-1+ubuntu17.10.1+deb.sury.org+1 (cli) (built: Oct 27 2017 13:50:57) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
    with Zend OPcache v7.1.11-1+ubuntu17.10.1+deb.sury.org+1, Copyright (c) 1999-2017, by Zend Technologies

I Added a var_dump just before the error, this gives me this:

object(PhpParser\Node\Stmt\TraitUseAdaptation\Alias)#5785 (5) {
  ["newModifier"]=>
  int(1)
  ["newName"]=>
  NULL
  ["trait"]=>
  NULL
  ["method"]=>
  string(11) "generateUrl"
  ["attributes":protected]=>
  array(2) {
    ["startLine"]=>
    int(536)
    ["endLine"]=>
    int(536)
  }
}

Can be reproduced with the following composer.json (just do composer install and run composer-require-checker on it):

{
    "require": {
        "symfony/framework-bundle": "^3.3"
    },
    "autoload": {
        "psr-4": { "\\MyNS\\": "./" }
    }
}

[Adirelle]

I just added a non-null check around the failing statement and it works, without breaking the test suite, but this seems too easy.

[maglnet]

@Adirelle the null check seems to be sufficient, since the parameter is only null when a visibility modifier has changed.

This happens here:
https://github.com/symfony/framework-bundle/blob/34b13d9e21146b9cd9914d48ccc086230f04bf32/Tests/Controller/ControllerTraitTest.php#L535

Just as a side note:
I first thought it was the "psr-4": { "\\MyNS\\": "./" } autoloader line that causes problems, but it can also be reproduced when running composer-require-checker within the repository symfony/framework-bundle.

[Adirelle]

#45 fixes it.