You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make c-cpp-unit-tests job in the agw-workflow required
What the check does
It currently runs all Bazel C/C++ test targets. As of Nov 30 2021, this includes SCTPD/LIAGENTD/CONNECTIOND/SESSIOND. Specifically, it runs bazel test //orc8r/gateway/c/...:* //lte/gateway/c/...:*. Any newly added C/C++ Bazel target will be included without any changes to the CI logic.
Improvements over the current solution
Single job for all C/C++ targets
The check covers any new test targets added under lte/gateway/c/ and orc8r/gateway/c/. So we will not need to add any new CI checks for every new service that we add under these directories.
Test summary upload
At the end of the test run, this check will upload an XML test summary to GitHub actions so that the failures can be easily seen.
On failure, you will see a comment on your PR
You can then click this check to see a more detailed summary.
Configuring re-run count for flaky tests
Bazel will automatically re-run any tests marked as flaky up to 3 times. This will be a major improvement as the current jobs do not attempt to re-run anything. For example, the SessionD unit test job has flaked out 3 / 25 runs as of today (Nov 30, 2021, master branch).
Speed
As we utilize Bazel and cache synching, most runs will take around 7 minutes. Note that this check currently runs unit tests for liagentd/sctpd/sessiond. To put this into perspective, the current SessionD job that only runs SessionD unit tests usually takes 9 minutes.
themarwhal
changed the title
Make c-cpp-unit-tests job in the agw-workflow required
Make c-cpp-unit-tests job (C/C++ unit tests) in the agw-workflow required
Dec 1, 2021
Make c-cpp-unit-tests job in the agw-workflow required
What the check does
It currently runs all Bazel C/C++ test targets. As of Nov 30 2021, this includes SCTPD/LIAGENTD/CONNECTIOND/SESSIOND. Specifically, it runs
bazel test //orc8r/gateway/c/...:* //lte/gateway/c/...:*
. Any newly added C/C++ Bazel target will be included without any changes to the CI logic.Improvements over the current solution
Single job for all C/C++ targets
The check covers any new test targets added under
lte/gateway/c/
andorc8r/gateway/c/
. So we will not need to add any new CI checks for every new service that we add under these directories.Test summary upload
At the end of the test run, this check will upload an XML test summary to GitHub actions so that the failures can be easily seen.
![Screen Shot 2021-11-30 at 7 32 16 PM](https://user-images.githubusercontent.com/37634144/144150193-3e685d34-cfbd-413f-a459-d6f3b407794d.png)
![Screen Shot 2021-11-30 at 7 32 34 PM](https://user-images.githubusercontent.com/37634144/144150213-638ca31b-41e4-4acc-be45-fb9f19a7a32e.png)
On failure, you will see a comment on your PR
You can then click
this check
to see a more detailed summary.Configuring re-run count for flaky tests
Bazel will automatically re-run any tests marked as
flaky
up to 3 times. This will be a major improvement as the current jobs do not attempt to re-run anything. For example, the SessionD unit test job has flaked out 3 / 25 runs as of today (Nov 30, 2021, master branch).Speed
As we utilize Bazel and cache synching, most runs will take around 7 minutes. Note that this check currently runs unit tests for liagentd/sctpd/sessiond. To put this into perspective, the current SessionD job that only runs SessionD unit tests usually takes 9 minutes.
Remediation steps for check failures
Our official documentation on AGW testing has been updated to include relevant Bazel commands.
Our CI blocking checklist doc has been updated to point to the doc above.
PR: #10561
For any issues that cannot be resolved by the docs above, I can be the POC.
Follow up actions
The text was updated successfully, but these errors were encountered: